Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable and update packages using agent service deployer - DO NOT MERGE #9862

Closed
wants to merge 10 commits into from

Conversation

mrodm
Copy link
Contributor

@mrodm mrodm commented May 14, 2024

Proposed commit message

Test to enable independent Elastic Agents for all packages using the latest changeset of elastic-package main branch.
Migrate auditd_manager and oracle packages that were using custom agents to use this new mode to run Elastic Agents.

  • Configuration/Settings for Elastic Agents is now defined in the configuration files for each system test.
  • _dev/deploy/agent folders removed, no longer needed.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.

Author's Checklist

  • Requires a new elastic-package version

How to test this PR locally

# Build/Install elastic-package from main
cd /path/elastic-package
make install

cd /path/integrations

# Start Elastic stack
elastic-package stack up -v -d

# Run system tests in any of the packages from integrations
cd /path/integrations/packages/<package>
ELASTIC_PACKAGE_TEST_ENABLE_INDEPENDENT_AGENT=true elastic-package test system -v

# Tear down Elastic stack
elastic-package stack down -v

Related issues

@mrodm mrodm self-assigned this May 14, 2024
@mrodm mrodm changed the title TEST - Enable and update packages using agent service deployer Enable and update packages using agent service deployer - DO NOT MERGE May 14, 2024
@mrodm
Copy link
Contributor Author

mrodm commented May 14, 2024

@flash1293 this PR that tests with the latest changes of elastic-package reports a package (zeronetworks) failing due to ignored fields cc @jsoriano

Here it is the link to the error: https://buildkite.com/elastic/integrations/builds/11433#018f778c-9382-496a-a782-af5796a25b70/679-1176

EDIT: there is at least one more package aws_bedrock (not finished yet the build):

@flash1293
Copy link
Contributor

@mrodm Ideally, the mapping issue should be investigated and fixed - e.g. if it is a keyword field that's running into ignore_above, maybe we don't need to index it at all or should index it as text? However, you should be able to also mute the error like this: #9823

@mrodm
Copy link
Contributor Author

mrodm commented May 14, 2024

@mrodm Ideally, the mapping issue should be investigated and fixed - e.g. if it is a keyword field that's running into ignore_above, maybe we don't need to index it at all or should index it as text? However, you should be able to also mute the error like this: #9823

Ok! This PR is not intended to be merged (at least for now). However, this is something that needs to be taken into account when a new elastic-package version is released and updated in the integrations repository, because it would require changes in packages. cc @elastic/ecosystem

@flash1293
Copy link
Contributor

flash1293 commented May 14, 2024

Yeah, the linked PR was meant to take care of this problem, but maybe some additional integrations had changes that made the check fail in new places. Lets wait for the build to finish, then I can create a PR to mute these errors as well.

Shows that we should release this additional check quickly so integration authors see the problem right away.

@elasticmachine
Copy link

elasticmachine commented May 14, 2024

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@flash1293
Copy link
Contributor

Opened PR here: #9871

@mrodm mrodm force-pushed the update-packages-independent-agents branch from ba7b262 to e5fa260 Compare May 16, 2024 17:15
mrodm added 6 commits May 21, 2024 09:53
Configuration for Elastic Agents is now defined in the configuration
files for the system tests.
Configuration for Elastic Agents is now defined in the configuration
files for the system tests.
@mrodm mrodm force-pushed the update-packages-independent-agents branch from e5fa260 to 71015b5 Compare May 21, 2024 07:57
@mrodm
Copy link
Contributor Author

mrodm commented May 21, 2024

/test

@elasticmachine
Copy link

elasticmachine commented May 21, 2024

⏳ Build in-progress, with failures

Failed CI Steps

History

cc @mrodm

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@botelastic
Copy link

botelastic bot commented Jun 21, 2024

Hi! We just realized that we haven't looked into this PR in a while. We're sorry! We're labeling this issue as Stale to make it hit our filters and make sure we get back to it as soon as possible. In the meantime, it'd be extremely helpful if you could take a look at it as well and confirm its relevance. A simple comment with a nice emoji will be enough :+1. Thank you for your contribution!

@botelastic botelastic bot added the Stalled label Jun 21, 2024
@mrodm mrodm closed this Jul 4, 2024
@mrodm mrodm deleted the update-packages-independent-agents branch July 4, 2024 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants